Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib): io test #2898

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(stdlib): io test #2898

wants to merge 3 commits into from
+171 −118

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Oct 4, 2024 •
edited
Loading

Description

Fixed a failing test in the io package. Additionally, I activated some previously commented-out tests by bypassing the need for os.CreateTemp using bytes.Buffer.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 4, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (8a62a28) to head (8414c6c).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2898   +/-   ##
=======================================
  Coverage   60.95%   60.96%           
=======================================
  Files         564      564           
  Lines       75273    75273           
=======================================
+ Hits        45884    45889    +5     
+ Misses      26019    26016    -3     
+ Partials     3370     3368    -2
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.92% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.11% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon changed the title fix io test fix(stdlib): io test Oct 4, 2024
@notJoon notJoon marked this pull request as ready for review October 4, 2024 06:04
@notJoon notJoon requested a review from thehowl as a code owner October 4, 2024 06:04
thehowl
thehowl requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of exporting the errors, I'd rather we kept them unexported and put the test in package io (instead of io_test).

@notJoon
Copy link
Member Author

notJoon commented Oct 4, 2024

Instead of exporting the errors, I'd rather we kept them unexported and put the test in package io (instead of io_test).

Changed the error types to private and modified the test package declaration from io_test to io.

The ErrShortWrite, EOF, ErrUnexpectedEOF, and ErrNoProgress errors remain public, as they are also used in the bufio package.

a63bb39

@notJoon notJoon requested a review from thehowl October 4, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl Awaiting requested review from thehowl thehowl is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@notJoon notJoon

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
💪 Bounties & Worx
Status: In Progress
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notJoon @thehowl